Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: #2414 - macro undo and redo tool #3613

Merged
merged 24 commits into from
Nov 27, 2023

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Nov 23, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

SashaGraves and others added 19 commits November 7, 2023 14:11
…ro-Undo-and-Redo-tool

# Conflicts:
#	packages/ketcher-core/src/domain/entities/DrawingEntitiesManager.ts
…-Redo-tool

# Conflicts:
#	packages/ketcher-core/src/application/editor/operations/polymerBond/index.ts
#	packages/ketcher-polymer-editor-react/src/Editor.tsx
#	packages/ketcher-polymer-editor-react/src/components/modal/Open/Open.tsx
- added/fixed tests
@rrodionov91 rrodionov91 linked an issue Nov 23, 2023 that may be closed by this pull request
…-Redo-tool

# Conflicts:
#	ketcher-autotests/tests/Settings/Atoms/atoms-settings.spec.ts
this.renderersContainer.update(modelChanges);
}

private onSelectHistory(name: string) {
const history = new EditorHistory(this);
if (name === 'undo') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create and use enum for 'undo' and 'redo' here and elsewhere? for example OperationType

…-Redo-tool

# Conflicts:
#	ketcher-autotests/tests/Macromolecule-editor/Chem-monomers/chem-library.spec.ts-snapshots/Open-Ketcher-Open-Chem-tab-in-library-1-chromium-linux.png
#	ketcher-autotests/tests/Macromolecule-editor/RNAEditor/add-default-presets.spec.ts-snapshots/Macromolecules-default-presets-Check-Guanine-in-default-presets-1-chromium-linux.png
#	ketcher-autotests/tests/Macromolecule-editor/RNAEditor/delete-preset.spec.ts-snapshots/Macromolecules-delete-RNA-presets-Should-not-delete-default-RNA-preset-1-chromium-linux.png
#	ketcher-autotests/tests/Macromolecule-editor/RNAEditor/rna-layout.spec.ts-snapshots/RNA-layout-Each-panel-is-collapsed-1-chromium-linux.png
#	ketcher-autotests/tests/Macromolecule-editor/RNAEditor/rna-layout.spec.ts-snapshots/RNA-layout-RNA-Builder-panel-is-collapsed-1-chromium-linux.png
@rrodionov91 rrodionov91 merged commit b6ff7dc into master Nov 27, 2023
5 checks passed
@rrodionov91 rrodionov91 deleted the 2414-Macro-Undo-and-Redo-tool branch November 27, 2023 09:16
captain2b pushed a commit that referenced this pull request Nov 28, 2023
* added menu buttons undo/redo, execute-invert commands
* added history, undo/redo for: add/delete/move bond/monomer, snake mode layout, clear canvas

---------

Co-authored-by: Sasha Graves <all0exa@gmail.com>
Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro: "Undo and Redo" tool
3 participants